[PATCH] D22792: VecClone Pass

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

Hello,

thank you for updating the patch.

I have added one more comment, and I also have a question. Could you please add (here or in a different patch) the plumbing needed in the LoopVectorizer to make the functions available for vectorizationvia this pass? Apologies if you have already done it and I am just missing it.

Francesco



================
Comment at: include/llvm/Analysis/VectorVariant.h:34-37
+#define STRIDE_KIND 's'
+#define LINEAR_KIND 'l'
+#define UNIFORM_KIND 'u'
+#define VECTOR_KIND 'v'
----------------
We will have to support OpenMP 4.5 linear modifiers, which are rendered as 2-char tokens in the mangled names. Woudn't it better to avoid #defines of chars and instead use enums inside the VectorKind class?


https://reviews.llvm.org/D22792