[PATCH] D39667: ELF: Merge DefinedRegular and Defined.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Symbols.h:95-97
   bool isUndefined() const { return SymbolKind == UndefinedKind; }
-  bool isDefined() const { return SymbolKind <= DefinedLast; }
+  bool isDefined() const { return SymbolKind == DefinedKind; }
   bool isShared() const { return SymbolKind == SharedKind; }
----------------
(off topic)

We should remove these functions and use isa<> instead. I think we needed them because some symbol subclasses were template classes, but not anymore.


================
Comment at: lld/ELF/Symbols.h:104
 
-  bool isInCurrentOutput() const {
-    return SymbolKind == DefinedRegularKind;
-  }
+  bool isInCurrentOutput() const { return isDefined(); }
 
----------------
I expect you'll remove this function in a follow-up patch.


https://reviews.llvm.org/D39667