[PATCH] D39394: Do not consider Shared symbols as defined symbols.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 4 17:37:35 PDT 2017
ruiu updated this revision to Diff 121607.
ruiu added a comment.
Herald added a subscriber: arichardson.
- Rebased
https://reviews.llvm.org/D39394
Files:
lld/ELF/Symbols.h
Index: lld/ELF/Symbols.h
===================================================================
--- lld/ELF/Symbols.h
+++ lld/ELF/Symbols.h
@@ -40,9 +40,9 @@
enum Kind {
DefinedFirst,
DefinedRegularKind = DefinedFirst,
- SharedKind,
DefinedCommonKind,
DefinedLast = DefinedCommonKind,
+ SharedKind,
UndefinedKind,
LazyArchiveKind,
LazyObjectKind,
@@ -247,13 +247,13 @@
static bool classof(const Symbol *S) { return S->kind() == UndefinedKind; }
};
-class SharedSymbol : public Defined {
+class SharedSymbol : public Symbol {
public:
static bool classof(const Symbol *S) { return S->kind() == SharedKind; }
SharedSymbol(StringRef Name, uint8_t StOther, uint8_t Type, uint64_t Value,
uint64_t Size, uint32_t Alignment, const void *Verdef)
- : Defined(SharedKind, Name, /*IsLocal=*/false, StOther, Type),
+ : Symbol(SharedKind, Name, /*IsLocal=*/false, StOther, Type),
Verdef(Verdef), Value(Value), Size(Size), Alignment(Alignment) {
// GNU ifunc is a mechanism to allow user-supplied functions to
// resolve PLT slot values at load-time. This is contrary to the
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39394.121607.patch
Type: text/x-patch
Size: 1161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171105/5910de99/attachment.bin>
More information about the llvm-commits
mailing list