[PATCH] D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of minors



================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:462
     if (N->getOperand(0).getValueType() == MVT::v8i32 ||
         N->getOperand(0).getValueType() == MVT::v8f32)
       return Subtarget->hasVLX();
----------------
RKSimon wrote:
> ```
> EVT OpVT = N->getOperand(0).getValueType();
> if (OpVT == MVT::v8i32 || OpVT == MVT::v8f32)
> ```
This is an NFC - commit it separately first.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:17259
+    SDValue A = peekThroughBitcasts(Op0);
+    if ((A.getOpcode() == ISD::AND || A.getOpcode() == X86ISD::FAND) &&
+        ISD::isBuildVectorAllZeros(Op1.getNode())) {
----------------
Remove empty line


https://reviews.llvm.org/D38732