[PATCH] D39616: [AMDGPU] Remove hardcoded address space value from AMDGPULibFunc

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPULibFunc.cpp:598
+    unsigned AS;
     if (!eatTerm(param, "U3AS")) {
+      AS = 0;
----------------
rampitec wrote:
> It changes meaning of the function signature. This shall be fine as long as library matches the expectations. Does it match?
If there is no U3AS, the address space value is 0. This is true for both the old and the new address space mapping. The library uses the same address space mapping as the runtime, so it is always consistent. 


https://reviews.llvm.org/D39616