[PATCH] D39623: [scudo] Rearrange #include order

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 16:44:47 PDT 2017


cryptoad updated this revision to Diff 121567.
cryptoad added a comment.

Additionally correct a ClangTidy warning (parameter consistency).


https://reviews.llvm.org/D39623

Files:
  lib/scudo/scudo_utils.h


Index: lib/scudo/scudo_utils.h
===================================================================
--- lib/scudo/scudo_utils.h
+++ lib/scudo/scudo_utils.h
@@ -14,10 +14,10 @@
 #ifndef SCUDO_UTILS_H_
 #define SCUDO_UTILS_H_
 
-#include <string.h>
-
 #include "sanitizer_common/sanitizer_common.h"
 
+#include <string.h>
+
 namespace __scudo {
 
 template <class Dest, class Source>
@@ -34,7 +34,7 @@
   CRC32CPUFeature = 0,
   MaxCPUFeature,
 };
-bool testCPUFeature(CPUFeature feature);
+bool testCPUFeature(CPUFeature Feature);
 
 INLINE u64 rotl(const u64 X, int K) {
   return (X << K) | (X >> (64 - K));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39623.121567.patch
Type: text/x-patch
Size: 608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171103/db6b0b83/attachment.bin>


More information about the llvm-commits mailing list