[PATCH] D39605: [debuginfo-tests] Decouple debuginfo-tests from the clang source tree.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 3 14:50:32 PDT 2017
probinson added a comment.
In https://reviews.llvm.org/D39605#915648, @zturner wrote:
> In https://reviews.llvm.org/D39605#915645, @probinson wrote:
>
> > At Sony we build our own unified tree by pasting together several subtrees, including debuginfo-tests, and moving one will cause a bit of disruption. I remember the idea of moving debuginfo-tests has come up previously, and in principle I have no problem with it, but a more explicit announcement on llvm-dev/cfe-dev would be appropriate.
>
>
> FWIW, debuginfo-tests is not actually checked out by default. You have to explicitly clone it at a location of your choosing. Before this patch, that location has to be `clang/test`, and after this patch, it has to be `llvm/projects`. How are your trees subtrees pasted together, is it something other than a mono-repo layout?
Yes, it's a homegrown unified tree with maybe a half-dozen projects and other internal cruft, done with subtree merges. Our internal tree does include debuginfo-tests. The upstream mono-repo didn't exist yet when we did this.
We can cope with what you're doing, but with the cmake changes not supporting debuginfo-tests in the old location, we'll need to fiddle with some of our automation so it ends up in the correct new place. If you can give us a few days that would be great.
https://reviews.llvm.org/D39605
More information about the llvm-commits
mailing list