[PATCH] D39550: [ELF] - Fix error reporting with --strip-debug/--strip-all.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 13:46:04 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

It's now much better.



================
Comment at: ELF/Driver.cpp:1120-1122
+  // When --strip-debug/--strip-all is given we want to remove debug sections
+  // from output, but we can not just discard them because use debug information
+  // for building error messages.
----------------
Just the first half should suffice.

  // We do not want to emit debug sections if --strip-all or -strip-debug are given.


https://reviews.llvm.org/D39550





More information about the llvm-commits mailing list