[PATCH] D38658: [cfi-verify] Add an interesting unit test where undef search length changes result.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 11:10:41 PDT 2017


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: unittests/tools/llvm-cfi-verify/FileAnalysis.cpp:654
+  uint64_t PrevSearchLengthForUndef = SearchLengthForUndef;
+  SearchLengthForUndef = 5;
   EXPECT_FALSE(Analysis.isIndirectInstructionCFIProtected(0xDEADBEEF + 9));
----------------
Maybe `SearchLengthForUndef` should be a field on `FileAnalysis`?


https://reviews.llvm.org/D38658





More information about the llvm-commits mailing list