[PATCH] D38367: [SLP] Added more missed optimiazation remarks

Adam Nemet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 09:45:58 PDT 2017


anemet added a comment.

I will look at the rest of the patch in more detail later unless Florian beats me to it.  Thanks for tackling this!



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4459-4462
+      std::string type_str;
+      llvm::raw_string_ostream rso(type_str);
+      Ty->print(rso);
+      // NOTE: the following will give user internal llvm type name, which may not be useful
----------------
Put these are under the closure so that we only compute them if the remark is on.


Repository:
  rL LLVM

https://reviews.llvm.org/D38367





More information about the llvm-commits mailing list