[PATCH] D39089: [AArch64][SVE] Asm: Add SVE (Z) Register definitions and parsing support
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 3 08:42:08 PDT 2017
rengolin added a comment.
Two nits, and I'm happy. :)
Welcoming any final comments from other reviewers.
================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:403
+
+ llvm_unreachable("Invalid access!");
}
----------------
I wouldn't change this, at least not in this patch. :)
================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:1749
}
+
};
----------------
whitespace change on separate patches.
https://reviews.llvm.org/D39089
More information about the llvm-commits
mailing list