[PATCH] D38367: [SLP] Added more missed optimiazation remarks

[Vladimir Miloserdov via Phabricator via llvm-commits]

miloserd marked 5 inline comments as done.
miloserd added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4459
+      return false;
+    if (Inst->getOpcode() != Opcode0) {
+      // FIXME: need more user-friendly message here
----------------
fhahn wrote:
> The code in the if branch does not use Inst, so could we keep `    if (!Inst || Inst->getOpcode() != Opcode0)` ?
It should only emit this remark if Inst is not null. And now it uses Inst anyway


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4460
+    if (Inst->getOpcode() != Opcode0) {
+      // FIXME: need more user-friendly message here
+      R.getORE()->emit(OptimizationRemarkMissed(SV_NAME, "InequableTypes", I0)
----------------
fhahn wrote:
> What would a better error message look like? We emit it if the the opcodes do not match. Would it make sense to add the opcodes to the message?
Rework it to emit instructions, I think it's better now


Repository:
  rL LLVM

https://reviews.llvm.org/D38367