[PATCH] D35702: [LTO][ThinLTO] Use the linker resolutions to mark global values as dso_local.
Sean Fertile via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 2 19:59:39 PDT 2017
sfertile marked an inline comment as done.
sfertile added inline comments.
================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:215
+ [](const std::unique_ptr<GlobalValueSummary> &Summary) {
+ return Summary->isDSOLocal();
+ });
----------------
pcc wrote:
> I think you need to check that all summaries are dso-local to protect against hash collisions here.
Good point. Updated.
Repository:
rL LLVM
https://reviews.llvm.org/D35702
More information about the llvm-commits
mailing list