[PATCH] D38417: [test-suite] Adding HACCKernels app

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 18:48:30 PDT 2017


hfinkel added inline comments.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/HACCKernels/GravityForceKernel.cpp:100
+//
+// Clang does not report a high enough version of openmp to enable the 
+// previous pragma.  Vectorization is desired regardless of openmp therefore
----------------
I suggest wording this as follows:

  // For the test suite: Clang does not report a high-enough version of OpenMP to enable the pragma below. Moreover, vectorization is desirable regardless of whether OpenMP is enabled (even if Clang's reported version were high enough), so we also use the Clang loop pragma to assume vectorization safety.


https://reviews.llvm.org/D38417





More information about the llvm-commits mailing list