[PATCH] D39459: Rename SymbolBody -> Symbol.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 2 14:06:46 PDT 2017
ruiu added a comment.
Sorry Geroge, but I completely disagree with you. Renaming variables needs human judgement, and mixing it with a mechanical change is a bad idea. We really should submit this first and then rename variables in follow-up patches.
Making a variable renaming change prior to submitting this change doesn't make sense because you can easily get the idea what it would look like. Actually creating a patch just increases the amount of human labor work because I would need to maintain it during review, and it would be painful as it would conflict with a lot of other patches.
Please do not overthink about this patch. We really don't need any clever planning at the moment.
https://reviews.llvm.org/D39459
More information about the llvm-commits
mailing list