[llvm] r317135 - [LLVM-C] Expose functions to create debug locations via DIBuilder.

[Adrian Prantl via llvm-commits]

side-note: The header was also missing header guards.

-- adrian

> On Nov 2, 2017, at 1:49 PM, Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> I can figure this out...
> 
> -- adrian
> 
>> On Nov 2, 2017, at 1:48 PM, Harlan Haskins <harlan at harlanhaskins.com> wrote:
>> 
>> I’m unfamiliar as well. I don’t know why DebugInfo.h isn’t being included here...
>> 
>>> On Nov 2, 2017, at 4:48 PM, whitequark <whitequark at whitequark.org> wrote:
>>> 
>>> Harlan,
>>> 
>>> Do you think you can send me a patch for this? I'm unfamiliar with the module system.
>>> 
>>> On 2017-11-02 20:31, Adrian Prantl wrote:
>>>>> On Nov 2, 2017, at 1:26 PM, Harlan Haskins <harlan at harlanhaskins.com> wrote:
>>>>> Seems like the module map just uses “.” for the umbrella directory. Not sure why this isn’t automatically inferred as part of the module…
>>>> That's right...
>>>> module LLVM_C {
>>>> umbrella "."
>>>> module * { export * }
>>>> }
>>>> -- adrian
>>>>>> On Nov 2, 2017, at 4:21 PM, Adrian Prantl <aprantl at apple.com> wrote:
>>>>>> +Harlan
>>>>>>> On Nov 2, 2017, at 1:20 PM, Adrian Prantl <aprantl at apple.com> wrote:
>>>>>>> It looks like this commit forgot to update the module map / or the umbrella header:
>>>>>>> /Data/llvm/lib/IR/DebugInfo.cpp:15:2: warning: missing submodule 'LLVM_C.DebugInfo' [-Wincomplete-umbrella]
>>>>>>> -- adrian
>>>>>>>> On Nov 1, 2017, at 3:18 PM, whitequark via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>>>>>>> Author: whitequark
>>>>>>>> Date: Wed Nov  1 15:18:52 2017
>>>>>>>> New Revision: 317135
>>>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=317135&view=rev
>>>>>>>> Log:
>>>>>>>> [LLVM-C] Expose functions to create debug locations via DIBuilder.
>>>>>>>> These include:
>>>>>>>> * Several functions for creating an LLVMDIBuilder,
>>>>>>>> * LLVMDIBuilderCreateCompileUnit,
>>>>>>>> * LLVMDIBuilderCreateFile,
>>>>>>>> * LLVMDIBuilderCreateDebugLocation.
>>>>>>>> Patch by Harlan Haskins.
>>>>>>>> Differential Revision: https://reviews.llvm.org/D32368
>>>>>>>> Added:
>>>>>>>> llvm/trunk/include/llvm-c/DebugInfo.h
>>>>>>>> llvm/trunk/test/Bindings/llvm-c/debug_info.ll
>>>>>>>> llvm/trunk/tools/llvm-c-test/debuginfo.c
>>>>>>>> Modified:
>>>>>>>> llvm/trunk/lib/IR/DebugInfo.cpp
>>>>>>>> llvm/trunk/tools/llvm-c-test/CMakeLists.txt
>>>>>>>> llvm/trunk/tools/llvm-c-test/llvm-c-test.h
>>>>>>>> llvm/trunk/tools/llvm-c-test/main.c
>>> 
>>> -- 
>>> whitequark
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits