[PATCH] D39511: [ELF] Support expressions with -defsym option

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/ScriptLexer.cpp:200
 
+// Split a given string as a defsym.
+static std::vector<StringRef> tokenizeDefsym(StringRef S) {
----------------
Please expand the comment to explain what form of input is expected.


================
Comment at: ELF/ScriptParser.cpp:274
+void ScriptParser::readDefsym() {
+  bool Orig = InDefsym;
+  InDefsym = true;
----------------
You create a new instance of ScriptParser for each -defsym string, so Orig is always the default value which is false.


Repository:
  rL LLVM

https://reviews.llvm.org/D39511