[PATCH] D39540: [llvm-nm] Print 'I' for import table data in COFF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D39540#914142, @smeenai wrote:

> > GNU binutils nm also flags all of the .idata$X chunks as 'i' (while this patch only makes it set on .idata$2 and .idata$6) and also flags impfunction as 'I'.
>
> This is just a consequence of how LLVM treats short import libraries, right? Considering that your patch returns 'i' for any `.idata` section, but short import libraries contain the ILT (`.idata$4`) and IAT (`.idata$5`) sections as `COFFImportFile` rather than `COFFObjectFile`.


There's a few such cases as well, but the ones I meant get a '?' instead because (I think) they trigger this case:

  Expected<section_iterator> SecIOrErr = SymI->getSection();
  if (!SecIOrErr) {
    consumeError(SecIOrErr.takeError());
    return '?';
  } 

(These are symbols pointing to zero byte sections.)


https://reviews.llvm.org/D39540