[PATCH] D39525: [cfi-verify] Add blacklist parsing for result filtering.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added a comment.

I think there are some mistakes in the (Un)?expected (Un)?protected summary description that should be fixed as well.



================
Comment at: tools/llvm-cfi-verify/lib/FileAnalysis.cpp:383
+
+      if (LineInfo->FileName == "<invalid>")
+        continue;
----------------
Will this do what we expect when !LineInfo?


================
Comment at: tools/llvm-cfi-verify/llvm-cfi-verify.cpp:109
+
+    if (SpecialCaseList->inSection("cfi-icall", "fun", LineInfo.FunctionName) ||
+        SpecialCaseList->inSection("cfi-icall", "fun", LineInfo.FunctionName)) {
----------------
vcall?


================
Comment at: unittests/tools/llvm-cfi-verify/GraphBuilder.cpp:129
   virtual void SetUp() {
+    IgnoreDWARF = true;
     SuccessfullyInitialised = true;
----------------
Could we rename this to IgnoreDwarfFlag? Would make it a little clearer what was happening here.


https://reviews.llvm.org/D39525