[PATCH] D39415: [ARMISelLowering] Better handling of NEON load/store for sequential memory regions

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a comment.

> I'm lost. What algorithm is O(N)? You have nested loops, the outer one is unbound, the inner one is O(N).

Having nested loops doesn't necessary means that you have O(N^2) complexity. My algorithm:

- Doesn't examine any node in the DAG twice
- Number of nodes in the DAG in N
- At maximum it can examine all nodes in DAG

So the complexity is naturally O(N)

> Testing on a single device is infinitely better than not testing it at all, I hope you can see that.

I've shown benchmarks on few Android phones, if you remember. I'll also try running full test suite, but this can take some time

> So you are expecting other people to test your code for you?

I'm not expecting anything. I just posted the fix.


https://reviews.llvm.org/D39415