[PATCH] D35702: [LTO][ThinLTO] Use the linker resolutions to mark global values as dso_local.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 2 11:21:21 PDT 2017
pcc added inline comments.
================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:215
+ [](const std::unique_ptr<GlobalValueSummary> &Summary) {
+ return Summary->isDSOLocal();
+ });
----------------
I think you need to check that all summaries are dso-local to protect against hash collisions here.
Repository:
rL LLVM
https://reviews.llvm.org/D35702
More information about the llvm-commits
mailing list