[PATCH] D36504: [CodeGenPrepare][WIP] Convert uncond. branch to return into a return to help with shrink-wrapping

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 10:50:36 PDT 2017


qcolombet added a comment.

> I don't know enough about shrink wrapping to know if that is feasible or not. It doesn't seem practical to me, but maybe Francis or Quentin can comment?

We'd actually want to do something relate to solve https://bugs.llvm.org/show_bug.cgi?id=33868.
We didn't have a chance to look at it yet.

What I'd like to have is a way to simulate critical edge splitting in DT and only materialize the basic block if we end up inserting something into it.

Don't know if splitting critical edges would solve what you are supporting here, though.

That being said, like Krzysztof said, I don't think CodeGenPrepare is the right place for this.


Repository:
  rL LLVM

https://reviews.llvm.org/D36504





More information about the llvm-commits mailing list