[PATCH] D39558: [TargetParser][AArch64] Reorder enum to preserve 5.0.0 libLLVM ABI.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D39558#914157, @mcrosier wrote:

> In https://reviews.llvm.org/D39558#914088, @rengolin wrote:
>
> > Why did they change in the first place?
>
>
> The reordering was arbitrary, but I didn't realize the implications at the time. :/


Been there, done that. :)

I don't think we need tests for testing the ordering. The original patch already had tests, we should be fine.

Also, this would be good to be on trunk as well as 5.0. We can't break binary compatibility between dot-releases, but we shouldn't do so on normal releases either, unless there's a reason.

--renato


https://reviews.llvm.org/D39558