[PATCH] D39503: Let replaceVTableHolder accept any type

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/DebugInfo/Generic/containing-type-extension.ll:24
+
+!0 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.4 (trunk 185475)", isOptimized: false, emissionKind: FullDebug, file: !1, enums: !2, retainedTypes: !2, globals: !15, imports: !2)
+!1 = !DIFile(filename: "CodeGen/dwarf-version.c", directory: "test")
----------------
tromey wrote:
> aprantl wrote:
> > Why not use DW_LANG_Rust and an actual example?
> It seemed better to me to have a minimal example; but I can make the DW_LANG_Rust change pretty easily.
My point was: it would be helpful to have actual Rust debug info code in the testcase to serve as a reminder hat kind of use-cases we need to support to guide future development/refactoring of LLVM. Having a minimal testcase is of course good, too, but I think in this case it would be nice to have an example of actual well-formed Rust debug info highlighting what Rust needs (and how it is different from clang). Can you generate a similarly small testcase from Rust?


https://reviews.llvm.org/D39503