[PATCH] D39491: [ELF] - Teach LLD to use information from .debug_str for error reporting.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 03:50:51 PDT 2017


>>
>> Index: test/ELF/conflict-debug-variable2.ll
>> ===================================================================
>> --- test/ELF/conflict-debug-variable2.ll
>> +++ test/ELF/conflict-debug-variable2.ll
>> @@ -0,0 +1,58 @@
>> +; REQUIRES: x86
>> +; RUN: llc %s -o %t.o -filetype=obj
>
>
>LGTM on the code change, but I would prefer a llvm-mc test. llc is
>probably just too unstable.
>
>Cheers,
>Rafael

Test uses llc because it was suggested during review of D38721:
https://reviews.llvm.org/D38721?id=118399#inline-338460,
I think main concern about using  llvm-mc was that test was auto generated and did
not have comments (because produced by gcc). 
But we still had to use assembly and committed version was reduced, and well-commented. 

llvm-mc allows us be more explicit in what we give to linker.
So I believe we can use it for this patch too.

I prepared version that uses llvm-mc: https://reviews.llvm.org/D39542.

George.


More information about the llvm-commits mailing list