[PATCH] D39463: [Analysis] Refine matching and merging of TBAA tags

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

This looks pretty good.

Please follow LLVM's coding conventions, especially for new functions, function names should start with a lower-case letter. findAccessType, not FindAccessType (see http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly).



================
Comment at: lib/Analysis/TypeBasedAliasAnalysis.cpp:565
+  // both the final access types belong to.
+  const MDNode *CommonGroup = GetLeastCommonTypeGroup(TagA.getAccessType(),
+                                                      TagB.getAccessType());
----------------
I don't like the terminology "type group". It's not finding a type group (we have no such things), it's finding a type. Can't we just call this: getLeastCommonType?


Repository:
  rL LLVM

https://reviews.llvm.org/D39463