[PATCH] D39503: Let replaceVTableHolder accept any type

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: test/DebugInfo/Generic/containing-type-extension.ll:8
+; CHECK: [[SP:.*]]: DW_TAG_structure_type
+; CHECK: DW_AT_containing_type [DW_FORM_ref4]       (cu + {{.*}}
+; CHECK: DW_AT_name [DW_FORM_strp] {{.*}}= "vtable")
----------------
You can omit the regex at the end of the line, FileCheck will look for the substring, similar to grep. 


================
Comment at: test/DebugInfo/Generic/containing-type-extension.ll:9
+; CHECK: DW_AT_containing_type [DW_FORM_ref4]       (cu + {{.*}}
+; CHECK: DW_AT_name [DW_FORM_strp] {{.*}}= "vtable")
+
----------------
You should use `CHECK-NEXT:` or add something like `CHECK-NOT: DW_TAG` between your `CHECK` lines to ensure that they actually belong to this `DW_TAG_structure_type`. 


Repository:
  rL LLVM

https://reviews.llvm.org/D39503