[PATCH] D39130: [yaml2obj][ELF] Add support for setting alignment in program headers

[Rafael Avila de Espindola via llvm-commits]

Jake Ehrlich via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> jakehehrlich updated this revision to Diff 120865.
> jakehehrlich retitled this revision from "[yaml2obj][ELF] Add support for setting alignment in program headers and fix default alignment" to "[yaml2obj][ELF] Add support for setting alignment in program headers".
> jakehehrlich added a comment.
>
> Rafael recommended that I split this into two separate changes. This change makes that split by removing the if-statment change that fixed default alignment.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D39130
>
> Files:
>   include/llvm/ObjectYAML/ELFYAML.h
>   lib/ObjectYAML/ELFYAML.cpp
>   test/tools/yaml2obj/program-header-align.yaml
>   tools/yaml2obj/yaml2elf.cpp
>
> Index: tools/yaml2obj/yaml2elf.cpp
> ===================================================================
> --- tools/yaml2obj/yaml2elf.cpp
> +++ tools/yaml2obj/yaml2elf.cpp
> @@ -378,15 +378,19 @@
>      }
>  
>      // Set the alignment of the segment to be the same as the maximum alignment
> -    // of the the sections with the same offset so that by default the segment
> +    // of the the sections in the segment so that by default the segment
>      // has a valid and sensible alignment.

The comment update should probably be on the second patch.

LGTM with that.

Cheers,
Rafael