[PATCH] D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added a comment.

I share the same concern as Peter, the TrigramIndex might save us from the performance hit but we are potentially blowing up the amount of regex comparisons we have to perform. With the very wide new cfi-icall blacklist in Chrome we will pass the TrigramIndex for significant parts of Chrome and all those entries are at the bottom of the list so we have to iteratively go through the entire blacklist before hitting those entries. I'd be curious to measure this for a Chrome build with use_cfi_icall=true specifically.



================
Comment at: lib/Support/SpecialCaseList.cpp:137
+    if (I->empty() || I->startswith("#")) {
+      ++LineNo;
       continue;
----------------
Doesn't the loop already handle this?


https://reviews.llvm.org/D39485