[PATCH] D39355: [dsymutil] Implement the --threads option

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/trunk/tools/dsymutil/dsymutil.cpp:66
+static opt<unsigned> Threads(
+    "threads",
+    desc("Specifies the maximum number (n) of simultaneous threads to use\n"
----------------
jgravelle-google wrote:
> For reasons I don't fully understand, this flag breaks the WebAssembly waterfall's build. https://wasm-stat.us/builders/linux/builds/25787
> 
> Our build uses `-DLLVM_BUILD_LLVM_DYLIB=ON` and `-DLLVM_LINK_LLVM_DYLIB=ON`, and we include lld, which my theory is then that both options are statically included in libLLVM, even though they should otherwise share no code. And that's problematic.
> Setting those to OFF, and even using `-DBUILD_SHARED_LIBS=ON` instead causes no issues.
> 
> I'm not entirely sure what to do about that and I'm pretty sure this isn't the right place for it, but this might get more eyes involved.
That's strange. llvm-cov and llvm-profdata both have a num-threads cl::opt, and we're not seeing the same issue there.


Repository:
  rL LLVM

https://reviews.llvm.org/D39355