[PATCH] D39012: AMDGPU: Merge BUFFER_STORE_DWORD_OFFEN/OFFSET into x2, x4

Marek Olšák via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 12:43:18 PDT 2017


mareko added a comment.

In https://reviews.llvm.org/D39012#903643, @nhaehnle wrote:

> One minor comment inline.
>
> The volatile / hasOrderedMemoryRef issue is worrying, and I don't think the change should go in as-is. Besides, it's probably not as big a win as the other patches, especially due to the added VGPR spills. Do you have all these patches in a branch somewhere?


The spills don't bother me because the shaders already spill VGPRs and any random codegen change tends to make it better or worse randomly. I will push my patches to some branch later.


https://reviews.llvm.org/D39012





More information about the llvm-commits mailing list