[PATCH] D38654: Parse DWARF information to reduce false positives.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 11:31:38 PDT 2017


pcc added a comment.

I'd expect there to be a test which makes sure that a jump with no line info in a file with line info doesn't count as an unprotected jump. Can you add one?



================
Comment at: test/tools/llvm-cfi-verify/X86/protected-nolineinfo.s:1
+# RUN: llvm-mc %s -filetype obj -triple x86_64-linux-elf -o %t.o
+# RUN: not llvm-cfi-verify %t.o 2>&1 | FileCheck %s
----------------
I don't think you need more than one test for the line table check. I'd drop this one and keep the other one.


https://reviews.llvm.org/D38654





More information about the llvm-commits mailing list