[PATCH] D37581: Implement pagerando wrapper functions to initialize POT register

[Peter Smith via Phabricator via llvm-commits]

peter.smith added inline comments.


================
Comment at: docs/LangRef.rst:1557
+    This attribute indicates that the function is compatible with pagerando and
+    will be located in a section which the dynamic loader can place at an
+    independent offset from any other section in the binary.
----------------
Is section the right word to use here? The compiler will place the function in a section, the linker will place that in an output section that will presumably be described, at least in ELF terms as a segment.


================
Comment at: lib/Transforms/IPO/PagerandoWrappers.cpp:101
+//
+// TODO: Support COMDAT
+static bool skipFunction(const Function &F) {
----------------
Are the issues surrounding comdat that at code-generation time that we can't guarantee at link time which comdat group is selected and it may not be the one with wrappers? If I'm write it would be useful to know, although not necessarily in this review, what ideas you have to resolve this?  


https://reviews.llvm.org/D37581