[llvm] r317000 - [Reassociate] Remove FIXME from looptest.ll (NFC)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 07:06:31 PDT 2017


Author: fhahn
Date: Tue Oct 31 07:06:31 2017
New Revision: 317000

URL: http://llvm.org/viewvc/llvm-project?rev=317000&view=rev
Log:
[Reassociate] Remove FIXME from looptest.ll (NFC)

Summary: The loop invariant add (i+j) is reassoicated, I think the FIXME can be removed, because this is what the test case tries to check (AFAIK). I also changed the test to use FileCheck.

Reviewers: mcrosier, davide

Reviewed By: mcrosier, davide

Subscribers: davide, llvm-commits

Differential Revision: https://reviews.llvm.org/D39424

Modified:
    llvm/trunk/test/Transforms/Reassociate/looptest.ll

Modified: llvm/trunk/test/Transforms/Reassociate/looptest.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Reassociate/looptest.ll?rev=317000&r1=316999&r2=317000&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/Reassociate/looptest.ll (original)
+++ llvm/trunk/test/Transforms/Reassociate/looptest.ll Tue Oct 31 07:06:31 2017
@@ -12,13 +12,14 @@
 ; In this case, we want to reassociate the specified expr so that i+j can be
 ; hoisted out of the inner most loop.
 ;
-; RUN: opt < %s -reassociate -S | grep 115 | not grep 117
+; RUN: opt < %s -reassociate -S | FileCheck %s
 ; END.
 @.LC0 = internal global [4 x i8] c"%d\0A\00"		; <[4 x i8]*> [#uses=1]
 
 declare i32 @printf(i8*, ...)
 
-; FIXME: No longer works.
+; Check that (i+j) has been reassociated (i=reg115, j=reg116)
+; CHECK: %reg113 = add i32 %reg116, %reg115
 define void @test(i32 %Num, i32* %Array) {
 bb0:
 	%cond221 = icmp eq i32 0, %Num		; <i1> [#uses=3]




More information about the llvm-commits mailing list