[PATCH] D39304: [IR] redefine 'reassoc' fast-math-flag and add 'trans' fast-math-flag

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: include/llvm/IR/Operator.h:220
+  void setApproxFunc()      { Flags |= ApproxFunc; }
+  void setFast()            { set(); }
 
----------------
wristow wrote:
> One loose end that needs to be taken care of more or less simultaneously is a Clang change.  Specifically, the constructor for `CodeGenFunction` (in "CodeGenFunction.cpp") invokes `FastMathFlags::setUnsafeAlgebra()`, so it will need to be changed to `setFast()`.
This is correct - I didn't post it, but I have that one line patch in place locally, so I was planning to submit it to the clang repo as close as possible after this patch and reference this commit (if there's a way to avoid the build breakage cleanly, please let me know).


https://reviews.llvm.org/D39304