[PATCH] D38494: [SCEV] Handling for ICmp occuring in the evolution chain.

Jun Ryung Ju via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 22:37:05 PDT 2017


junryoungju added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:4789
   // If the value coming around the backedge is an add with the symbolic
   // value we just inserted, then we found a simple induction variable!
   if (const SCEVAddExpr *Add = dyn_cast<SCEVAddExpr>(BEValue)) {
----------------
junryoungju wrote:
> Is that really evolutable if BEValue is not a AddExpr?
> we cannot assume that is always AddExpr.
> 
> this cannot evolute if isn't a AddExpr.
This still didn't fixed.
You should try clang output to this patch emits correct optimized assemblies that commented on original bug report.


https://reviews.llvm.org/D38494





More information about the llvm-commits mailing list