[PATCH] D39443: [ThinLTO] Double bits of module hash used for renaming
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 30 19:25:19 PDT 2017
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:746
NewName += ".llvm.";
- NewName += utostr(ModHash[0]); // Take the first 32 bits
+ NewName += utostr(((uint64_t)ModHash[0] << 32) |
+ ModHash[1]); // Take the first 64 bits
----------------
I'd write `uint64_t(ModHash[0]) << 32` to make it unambiguous what is being extended.
https://reviews.llvm.org/D39443
More information about the llvm-commits
mailing list