[PATCH] D39404: DAG: Add nuw when splitting loads and stores

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 19:17:44 PDT 2017

Previous message: [PATCH] D39443: [ThinLTO] Double bits of module hash used for renaming
Next message: [PATCH] D39404: DAG: Add nuw when splitting loads and stores
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

hfinkel added a comment.

Looks right to me. Regarding a helper, the comment is longer than the code, so you should name the helper so that you can move the comment too. Maybe getObjectOffsetWrapFlags or similar.


https://reviews.llvm.org/D39404

Previous message: [PATCH] D39443: [ThinLTO] Double bits of module hash used for renaming
Next message: [PATCH] D39404: DAG: Add nuw when splitting loads and stores
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list