[PATCH] D38907: Give .note.gnu.build-id section alignment 4

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 13:54:05 PDT 2017


So this LGTM if a testcase is added.

Cheers,
Rafael

Roland McGrath <mcgrathr at google.com> writes:

> I'm not actively doing anything with it.  Perhaps Jake would like to follow
> through.
>
> Despite what the so-called "spec" says, in actual fact, the note header's
> fields are 32-bit in both ELFCLASS32 and ELFCLASS64 and the expected
> alignment is always 4.
>
> On Mon, Oct 30, 2017 at 11:22 AM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> Is anyone still working on this?
>>
>> It should have a testcase and probably align to 8 on 64 bits, but change
>> is a good one.
>>
>> Cheers,
>> Rafael
>>
>> George Rimar via Phabricator via llvm-commits
>> <llvm-commits at lists.llvm.org> writes:
>>
>> > grimar added a comment.
>> >
>> > Probably needs testcase ?
>> >
>> >
>> > Repository:
>> >   rL LLVM
>> >
>> > https://reviews.llvm.org/D38907
>> >
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>


More information about the llvm-commits mailing list