[PATCH] D37093: [coroutines] Promote cleanup.dest.slot-like allocas to registers to avoid storing them in the coroutine frame
John McCall via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 30 11:51:50 PDT 2017
rjmccall added a comment.
In https://reviews.llvm.org/D37093#910909, @GorNishanov wrote:
> @rjmccall suggested to do the cleanup dest slot elimination wholesale for all functions in clang. (Not specific for coroutines).
> That is a sweeping change :-), so, I don't mind still having this here to unblock Facebook and when the clang change lands, remove this part from llvm.
Well, I said that I wouldn't be opposed to cleaning up the cleanup dest slot unconditionally. I expressed no opinion about whether that was a reasonable way to fix this problem in your representation. (This doesn't affect my lowering as coro.end is always a terminator.)
https://reviews.llvm.org/D37093
More information about the llvm-commits
mailing list