[PATCH] D39424: [Reassociate] Remove FIXME from looptest.ll (NFC)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 09:42:04 PDT 2017


fhahn created this revision.

The loop invariant add (i+j) is reassoicated, I think the FIXME can be removed, because this is what the test case tries to check (AFAIK). I also changed the test to use FileCheck.


https://reviews.llvm.org/D39424

Files:
  test/Transforms/Reassociate/looptest.ll


Index: test/Transforms/Reassociate/looptest.ll
===================================================================
--- test/Transforms/Reassociate/looptest.ll
+++ test/Transforms/Reassociate/looptest.ll
@@ -12,13 +12,14 @@
 ; In this case, we want to reassociate the specified expr so that i+j can be
 ; hoisted out of the inner most loop.
 ;
-; RUN: opt < %s -reassociate -S | grep 115 | not grep 117
+; RUN: opt < %s -reassociate -S | FileCheck %s
 ; END.
 @.LC0 = internal global [4 x i8] c"%d\0A\00"		; <[4 x i8]*> [#uses=1]
 
 declare i32 @printf(i8*, ...)
 
-; FIXME: No longer works.
+; Check that (i+j) has been reassociated (i=reg115, j=reg116)
+; CHECK: %reg113 = add i32 %reg116, %reg115
 define void @test(i32 %Num, i32* %Array) {
 bb0:
 	%cond221 = icmp eq i32 0, %Num		; <i1> [#uses=3]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39424.120840.patch
Type: text/x-patch
Size: 800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171030/20d70ead/attachment.bin>


More information about the llvm-commits mailing list