[PATCH] D38566: [SimplifyCFG] don't sink common insts too soon (PR34603)

[Sanjay Patel via Phabricator via llvm-commits]

spatel updated this revision to Diff 120830.
spatel added a comment.
Herald added subscribers: javed.absar, mehdi_amini.

Patch updated:
Now that we have SimplifyCFGOptions exposed to the pass managers, we can use a precise disablement of sinking common instructions to only the first instantiation of -simplifycfg (the one that runs before early-cse).

Depending on your perspective, this is either a redefinition of "canonical form" or we've created a new "pre-canonical form".

Given the comments in PR34603, I suspect we want to limit simplifycfg sinking even more, but that should be a follow-up patch with more phase ordering tests, so we know exactly what kind of patterns we're affecting.


https://reviews.llvm.org/D38566

Files:
  include/llvm/Transforms/Scalar.h
  include/llvm/Transforms/Scalar/SimplifyCFG.h
  include/llvm/Transforms/Utils/Local.h
  lib/Passes/PassBuilder.cpp
  lib/Target/ARM/ARMTargetMachine.cpp
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/Scalar/SimplifyCFGPass.cpp
  lib/Transforms/Utils/SimplifyCFG.cpp
  test/Transforms/PhaseOrdering/simplifycfg-options.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38566.120830.patch
Type: text/x-patch
Size: 8919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171030/8579c137/attachment.bin>