[PATCH] D39390: Move isDSOLocal check and add a comment

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 08:39:54 PDT 2017


sfertile added a comment.

This LGTM.



================
Comment at: lib/Target/TargetMachine.cpp:117
                                          const GlobalValue *GV) const {
+  // If the front end requested that this GV be treated as dso local, obey.
+  if (GV && GV->isDSOLocal())
----------------
minor nit: it might not be the front-end that set the value, the lto backends could refine a GV to dso_local using the symbol resolutions the linker provides.


https://reviews.llvm.org/D39390





More information about the llvm-commits mailing list