[PATCH] D39232: [CodeGen][ExpandMemcmp] Allow memcmp to expand to vector loads (2).

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 06:45:01 PDT 2017


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - thanks! See inline comment for a nit.



================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:2541-2542
+X86TTIImpl::enableMemCmpExpansion(bool IsZeroCmp) const {
+  // Only enable vector loads for equality comparison, as we don't have a
+  // vector bswap.
+  static const auto ThreeWayOptions = [this]() {
----------------
This isn't strictly a question of bswap availability - see the suggested code in:
https://bugs.llvm.org/show_bug.cgi?id=33329


https://reviews.llvm.org/D39232





More information about the llvm-commits mailing list