[PATCH] D38031: Adding a shufflevector and select LLVM IR instructions fuzz tool

[Gadi Haber via Phabricator via llvm-commits]

gadi.haber added inline comments.


================
Comment at: utils/shuffle_select_fuzz.py:3
+
+"""A shuffle-select vector fuzz tester.
+
----------------
consider modifying the script name to add the word "generate" or "test"  ?


================
Comment at: utils/shuffle_select_fuzz.py:13
+Take the output IR printed to stdout, compile it to an executable using whatever
+set of transforms you want to test, and run the program. If it crashes, it found
+a bug.
----------------
prints out an error message and crashes.


================
Comment at: utils/shuffle_select_fuzz.py:333
+                      help='A string used to seed the RNG')
+  parser.add_argument('--max-num-inputs', type=int, default=20,
+                      help='Specify the maximum number of vector inputs for the test')
----------------
Add the default to the help message


================
Comment at: utils/shuffle_select_fuzz.py:335
+                      help='Specify the maximum number of vector inputs for the test')
+  parser.add_argument('--min-num-inputs', type=int, default=10,
+                      help='Specify the minimum number of vector inputs for the test')
----------------
Add the default to the help string message,


https://reviews.llvm.org/D38031