[PATCH] D39369: [GVN][NFC] Mark instruction for deletion instead of immediate erasing in LoadPRE

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Transforms/Scalar/GVN.cpp:1838
 bool GVN::processInstruction(Instruction *I) {
   // Ignore dbg info intrinsics.
   if (isa<DbgInfoIntrinsic>(I))
----------------
reames wrote:
> Looking at the code for InstsToErase, it looks like there's an invariant that the map is empty between every instruction.  Can you add an assert here to that effect if you agree with the analysis?
I will double-check this and commit as a separate NFC.


https://reviews.llvm.org/D39369