[PATCH] D39406: Merge SymbolBody and Symbol into one class, SymbolBody.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D39406#910260, @ruiu wrote:

> The size of the symbol remains the same 88 bytes.


Yes, the size of global symbols will be the same, but you're increasing the sizes of the unparented local symbols. I'd expect there to be a large number of these (especially with function sections).

> If we have to pack it better, we can do it by tweaking some members of SymbolBody, but looks like the program isn't very sensitive to the size of Symbol.

If that's what you've measured, this seems fine to me.



================
Comment at: lld/docs/NewLLD.rst:167
-
-  As the resolver reads symbols from input files, it replaces the Symbol's
-  SymbolBody with the "best" SymbolBody for its symbol name by constructing
----------------
Is it worth keeping this para (maybe move into SymbolTable)?


https://reviews.llvm.org/D39406