[PATCH] D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1

michael zuckerman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 29 06:18:59 PDT 2017


m_zuckerman added a comment.

In https://reviews.llvm.org/D39292#909380, @craig.topper wrote:

> We shouldn’t rely on pattern order in the td file if we can avoid it. So a pattern that is for when DQI is disabled should have a no DQI predicate.
>
> But in this case I see no good reason to have two different patterns. Why can’t we use KSHIFTW even when DQI is enabled? Is there a downside?


You are right, we can use the KSHIFTW.


https://reviews.llvm.org/D39292





More information about the llvm-commits mailing list