[lld] r316846 - Do not handle DefinedCommon symbols in the MapFile writer.

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Sat Oct 28 14:11:38 2017
New Revision: 316846

URL: http://llvm.org/viewvc/llvm-project?rev=316846&view=rev
Log:
Do not handle DefinedCommon symbols in the MapFile writer.

Because of r314495 which converts DefinedCommon symbols to DefinedRegular
symbols, common symbols are no longer reachable to the MapFile writer.
So the code to handle common symbols is now dead.

Modified:
    lld/trunk/ELF/MapFile.cpp

Modified: lld/trunk/ELF/MapFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MapFile.cpp?rev=316846&r1=316845&r2=316846&view=diff
==============================================================================
--- lld/trunk/ELF/MapFile.cpp (original)
+++ lld/trunk/ELF/MapFile.cpp Sat Oct 28 14:11:38 2017
@@ -26,9 +26,7 @@
 #include "Strings.h"
 #include "SymbolTable.h"
 #include "SyntheticSections.h"
-
 #include "lld/Common/Threads.h"
-
 #include "llvm/Support/raw_ostream.h"
 
 using namespace llvm;
@@ -51,30 +49,21 @@ static std::string indent(int Depth) { r
 // Returns a list of all symbols that we want to print out.
 static std::vector<Defined *> getSymbols() {
   std::vector<Defined *> V;
-  for (InputFile *File : ObjectFiles) {
-    for (SymbolBody *B : File->getSymbols()) {
-      if (auto *DR = dyn_cast<DefinedRegular>(B)) {
+  for (InputFile *File : ObjectFiles)
+    for (SymbolBody *B : File->getSymbols())
+      if (auto *DR = dyn_cast<DefinedRegular>(B))
         if (DR->getFile() == File && !DR->isSection() && DR->Section &&
             DR->Section->Live)
           V.push_back(DR);
-      } else if (auto *DC = dyn_cast<DefinedCommon>(B)) {
-        if (DC->Section)
-          V.push_back(DC);
-      }
-    }
-  }
   return V;
 }
 
 // Returns a map from sections to their symbols.
 static SymbolMapTy getSectionSyms(ArrayRef<Defined *> Syms) {
   SymbolMapTy Ret;
-  for (Defined *S : Syms) {
+  for (Defined *S : Syms)
     if (auto *DR = dyn_cast<DefinedRegular>(S))
       Ret[DR->Section].push_back(S);
-    else if (auto *DC = dyn_cast<DefinedCommon>(S))
-      Ret[DC->Section].push_back(S);
-  }
 
   // Sort symbols by address. We want to print out symbols in the
   // order in the output file rather than the order they appeared