[llvm] r316840 - [X86] Fix a mistake in the X86ISelDAGToDAG.cpp code for MUL8r/IMUL8r.
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 28 12:56:57 PDT 2017
Author: ctopper
Date: Sat Oct 28 12:56:57 2017
New Revision: 316840
URL: http://llvm.org/viewvc/llvm-project?rev=316840&view=rev
Log:
[X86] Fix a mistake in the X86ISelDAGToDAG.cpp code for MUL8r/IMUL8r.
I think this code is unreachable due to some promotions that occur elsewhere. I'll look into that to be sure, but for now I thought I should at least fix the obvious typo.
Modified:
llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
Modified: llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp?rev=316840&r1=316839&r2=316840&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp Sat Oct 28 12:56:57 2017
@@ -2728,7 +2728,7 @@ void X86DAGToDAGISel::Select(SDNode *Nod
// Get the low part if needed. Don't use getCopyFromReg for aliasing
// registers.
if (!SDValue(Node, 0).use_empty())
- ReplaceUses(SDValue(Node, 1),
+ ReplaceUses(SDValue(Node, 0),
CurDAG->getTargetExtractSubreg(X86::sub_8bit, dl, MVT::i8, Result));
// Shift AX down 8 bits.
More information about the llvm-commits
mailing list